Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CI tests weren't running [DT-7060] #87

Merged
merged 2 commits into from
Feb 12, 2025
Merged

fix: CI tests weren't running [DT-7060] #87

merged 2 commits into from
Feb 12, 2025

Conversation

lanesawyer
Copy link
Collaborator

@lanesawyer lanesawyer commented Feb 12, 2025 •
edited
Loading

What

  • Apparently we didn't actually have a test:ci command, so the test CI step was just saying "there's nothing to do" lol

How

  • Adds "test:ci": "vitest run" to run the tests (the run command on vitest doesn't enter watch mode)
  • Added build step to the tests so that the libraries are all ready to be used by higher-level packages

Screenshots

image

PR Checklist

  • Is your PR title following our conventional commit naming recommendations?
  • Have you filled in the PR Description Template?
  • Is your branch up to date with the latest in main?
  • Do the CI checks pass successfully?
  • Have you smoke tested the example applications?
  • Did you check that the changes meet accessibility standards?
  • Have you tested the application on these browsers?
    • Chrome (Fully supported)
    • Firefox (Major bug fixes supported)
    • Safari (Major bug fixes supported)

@lanesawyer lanesawyer requested a review from a team as a code owner February 12, 2025 00:22
Jarbuckle
Jarbuckle approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@Jarbuckle Jarbuckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config changes look good, pnpm run test:ci runs as expected for each package locally; approved!

@lanesawyer lanesawyer merged commit fc3eeb6 into main Feb 12, 2025
4 of 5 checks passed
@lanesawyer lanesawyer deleted the lane/DT-7060-fix-ci-tests branch February 12, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarbuckle Jarbuckle Jarbuckle approved these changes

@jessicamalloy jessicamalloy Awaiting requested review from jessicamalloy jessicamalloy is a code owner automatically assigned from AllenInstitute/app-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lanesawyer @Jarbuckle