refactor: Refactor of the publish path and HttpTransport #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files |
To improve the testability of publishing a package, `PyOci.publish_package()` is split into multiple methods. Tests for the refactored parts were moved/restructured so it is no longer needed to go through the entire request flow for every test (including mockito). A new Trait `Transport` is introduced and `PyOci` is generic over `Transport`. This allows swapping the `HttpTransport` in unittests in the future, removing the need to mockito in a lot of cases. Annotations have been structured a bit more. - ImageIndex annotations will only include it's creation timestamp - ImageIndex.manifests[] annotations will include package metadata we might need when listing/searching packages - ImageManifest annotations will contain user-defined labels through `PyOci :: Label :: ` classifiers. The `com.pyoci.sha256_digest` annotation is added containing the SHA256 digest of the package blob. This is a first step to make #160 work in an effective manner. The SHA256 digest of the provided content is checked against the provided `sha256_digest` in the request.
AllexVeldman
force-pushed
the
refactor/testability
branch
from
73d22ae to
f006377
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve the testability of publishing a package,
PyOci.publish_package()is split into multiple methods.Tests for the refactored parts were moved/restructured so it is no longer needed to go through the entire request flow for every test (including mockito).
A new Trait
Transportis introduced andPyOciis generic overTransport.This allows swapping the
HttpTransportin unittests in the future, removing the need to mockito in a lot of cases.Annotations have been structured a bit more.
PyOci :: Label ::classifiers.The
com.pyoci.sha256_digestannotation is added containing the SHA256 digest of the package blob.This is a first step to make #160 work in an effective manner.
BEGIN_COMMIT_OVERRIDE
refactor: Refactor of the publish path and HttpTransport #162
feat: SHA256 digest of the provided content is checked against the provided
sha256_digestin the request. #162END_COMMIT_OVERRIDE