Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to consumed capacity parsing #227

Merged
merged 3 commits into from
Apr 27, 2024
Merged

Conversation

firenero
Copy link
Contributor

@firenero firenero commented Feb 5, 2024

Additions:

  1. Exposed consumed capacity high-level API for batch requests. Addresses No way to set ReturnConsumedCapacity for BatchGet and BatchWrite requests using builders #222.

Bugfixes:

  1. ConsumedCapacity was not parsed at all for DeleteItem operation due to incorrect JSON name mapping.
  2. TransactWrite returns a list of consumed capacities (one item per table) but the previous version mapped it to a single item. This is technically a breaking change because it changes public property. However, attempts to get consumed capacity data for TransactWrite always resulted in a crash, so this should not break any real users.
  3. Table property in FullConsumedCapacity was not mapped from JSON in all operations.

@firenero firenero requested a review from lezzi February 5, 2024 02:35
@firenero firenero self-assigned this Feb 5, 2024
@firenero firenero merged commit a52c374 into main Apr 27, 2024
1 check passed
@firenero firenero deleted the firenero/batch-api branch April 27, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant