Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TokenScript view #3344

Merged
merged 6 commits into from
Dec 27, 2023
Merged

Fix TokenScript view #3344

merged 6 commits into from
Dec 27, 2023

Conversation

JamesSmartCell
Copy link
Member

  • TokenScript view displays new xNFTs correctly.
  • TokenScript correctly updates attributes and setAction attribute values.

Copy link

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 84 lines in your changes are missing coverage. Please review.

Comparison is base (9dc6963) 7.13% compared to head (53c237c) 7.12%.

Files Patch % Lines
...et/app/entity/tokenscript/TokenscriptFunction.java 0.00% 19 Missing ⚠️
...com/alphawallet/app/ui/NFTAssetDetailActivity.java 0.00% 13 Missing ⚠️
...hawallet/app/viewmodel/TokenFunctionViewModel.java 0.00% 13 Missing ⚠️
...lphawallet/app/service/AssetDefinitionService.java 0.00% 9 Missing ⚠️
...m/alphawallet/app/ui/AdvancedSettingsActivity.java 0.00% 9 Missing ⚠️
...n/java/com/alphawallet/app/web3/Web3TokenView.java 0.00% 7 Missing ⚠️
.../java/com/alphawallet/app/widget/NFTImageView.java 0.00% 5 Missing ⚠️
...in/java/com/alphawallet/app/entity/UpdateType.java 0.00% 4 Missing ⚠️
.../java/com/alphawallet/app/ui/FunctionActivity.java 0.00% 2 Missing ⚠️
.../com/alphawallet/app/widget/FunctionButtonBar.java 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##             master   #3344      +/-   ##
===========================================
- Coverage      7.13%   7.12%   -0.01%     
  Complexity      893     893              
===========================================
  Files           676     677       +1     
  Lines         46687   46725      +38     
  Branches       4734    4745      +11     
===========================================
  Hits           3330    3330              
- Misses        43056   43094      +38     
  Partials        301     301              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamesSmartCell JamesSmartCell merged commit 3d45201 into master Dec 27, 2023
7 of 9 checks passed
@JamesSmartCell JamesSmartCell deleted the Fix-TokenScript-View branch December 27, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant