Improve TokenIcon #3365
Merged
Improve TokenIcon #3365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JamesSmartCell
commented
Mar 10, 2024
JamesSmartCell
commented
- Improve TokenIcon class
- Fix Opensea API feed.
Pull reviewers statsStats of the last 30 days for alpha-wallet-android:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
app/src/main/java/com/alphawallet/app/service/OpenSeaService.java
Outdated
Show resolved
Hide resolved
app/build.gradle
Outdated
| @@ -330,7 +315,7 @@ dependencies { | |||
| androidTestImplementation 'androidx.test.ext:junit:1.1.3' | |||
| androidTestImplementation 'androidx.test.uiautomator:uiautomator:2.2.0' | |||
There was a problem hiding this comment.
| Warning |
|
|---|---|
| 📚 | Use version catalog instead |
| 🛠️ | UseTomlInstead |
by Android Lint 🤖
app/build.gradle
Outdated
| @@ -330,7 +315,7 @@ dependencies { | |||
| androidTestImplementation 'androidx.test.ext:junit:1.1.3' | |||
| androidTestImplementation 'androidx.test.uiautomator:uiautomator:2.2.0' | |||
| androidTestImplementation 'androidx.test.espresso:espresso-contrib:3.3.0' | |||
| androidTestImplementation 'androidx.browser:browser:1.5.0' | |||
| androidTestImplementation 'androidx.browser:browser:1.8.0' | |||
|
|
|||
| // Unit tests | |||
| testImplementation 'junit:junit:4.13.2' | |||
There was a problem hiding this comment.
| Warning |
|
|---|---|
| 📚 | Use the existing version catalog reference (libs.junit) instead |
| 🛠️ | UseTomlInstead |
by Android Lint 🤖
app/build.gradle
Outdated
| @@ -330,7 +318,7 @@ dependencies { | |||
| androidTestImplementation 'androidx.test.ext:junit:1.1.3' | |||
There was a problem hiding this comment.
| Warning |
|
|---|---|
| 📚 | Use version catalog instead (androidx.test.ext:junit is already available as ext-junit, but using version 1.1.5 instead) |
| 🛠️ | UseTomlInstead |
by Android Lint 🤖
app/build.gradle
Outdated
| @@ -330,7 +318,7 @@ dependencies { | |||
| androidTestImplementation 'androidx.test.ext:junit:1.1.3' | |||
| androidTestImplementation 'androidx.test.uiautomator:uiautomator:2.2.0' | |||
There was a problem hiding this comment.
| Warning |
|
|---|---|
| 📚 | Use version catalog instead |
| 🛠️ | UseTomlInstead |
by Android Lint 🤖
app/build.gradle
Outdated
| @@ -330,7 +318,7 @@ dependencies { | |||
| androidTestImplementation 'androidx.test.ext:junit:1.1.3' | |||
| androidTestImplementation 'androidx.test.uiautomator:uiautomator:2.2.0' | |||
| androidTestImplementation 'androidx.test.espresso:espresso-contrib:3.3.0' | |||
There was a problem hiding this comment.
| Warning |
|
|---|---|
| 📚 | Use version catalog instead |
| 🛠️ | UseTomlInstead |
by Android Lint 🤖
| implementation platform('com.fasterxml.jackson:jackson-bom:2.13.5') //Don't upgrade from 2.13.5 due to Android API24 compatibility | ||
|
|
||
| //noinspection BomWithoutPlatform,GradleDependency | ||
| implementation platform('com.fasterxml.jackson:jackson-bom:2.13.5') //Do not upgrade! 2.13.5 is latest library with Android API24 compatibility |
There was a problem hiding this comment.
| Warning |
|
|---|---|
| 📚 | Use version catalog instead |
| 🛠️ | UseTomlInstead |
by Android Lint 🤖
| implementation platform('com.fasterxml.jackson:jackson-bom:2.13.5') //Don't upgrade from 2.13.5 due to Android API24 compatibility | ||
|
|
||
| //noinspection BomWithoutPlatform,GradleDependency | ||
| implementation platform('com.fasterxml.jackson:jackson-bom:2.13.5') //Do not upgrade! 2.13.5 is latest library with Android API24 compatibility | ||
| implementation 'com.fasterxml.jackson.core:jackson-core' |
There was a problem hiding this comment.
| Warning |
|
|---|---|
| 📚 | Use version catalog instead |
| 🛠️ | UseTomlInstead |
by Android Lint 🤖
| implementation platform('com.fasterxml.jackson:jackson-bom:2.13.5') //Don't upgrade from 2.13.5 due to Android API24 compatibility | ||
|
|
||
| //noinspection BomWithoutPlatform,GradleDependency | ||
| implementation platform('com.fasterxml.jackson:jackson-bom:2.13.5') //Do not upgrade! 2.13.5 is latest library with Android API24 compatibility | ||
| implementation 'com.fasterxml.jackson.core:jackson-core' | ||
| implementation 'com.fasterxml.jackson.core:jackson-databind' |
There was a problem hiding this comment.
| Warning |
|
|---|---|
| 📚 | Use version catalog instead |
| 🛠️ | UseTomlInstead |
by Android Lint 🤖
app/build.gradle
Outdated
| @@ -330,7 +318,7 @@ dependencies { | |||
| androidTestImplementation 'androidx.test.ext:junit:1.1.3' | |||
| androidTestImplementation 'androidx.test.uiautomator:uiautomator:2.2.0' | |||
| androidTestImplementation 'androidx.test.espresso:espresso-contrib:3.3.0' | |||
| androidTestImplementation 'androidx.browser:browser:1.5.0' | |||
| androidTestImplementation 'androidx.browser:browser:1.8.0' | |||
There was a problem hiding this comment.
| Warning |
|
|---|---|
| 📚 | Use version catalog instead |
| 🛠️ | UseTomlInstead |
by Android Lint 🤖
app/build.gradle
Outdated
| @@ -330,7 +318,7 @@ dependencies { | |||
| androidTestImplementation 'androidx.test.ext:junit:1.1.3' | |||
| androidTestImplementation 'androidx.test.uiautomator:uiautomator:2.2.0' | |||
| androidTestImplementation 'androidx.test.espresso:espresso-contrib:3.3.0' | |||
| androidTestImplementation 'androidx.browser:browser:1.5.0' | |||
| androidTestImplementation 'androidx.browser:browser:1.8.0' | |||
|
|
|||
| // Unit tests | |||
| testImplementation 'junit:junit:4.13.2' | |||
There was a problem hiding this comment.
| Warning |
|
|---|---|
| 📚 | Use the existing version catalog reference (libs.junit) instead |
| 🛠️ | UseTomlInstead |
by Android Lint 🤖
| implementation platform('com.fasterxml.jackson:jackson-bom:2.13.5') //Don't upgrade from 2.13.5 due to Android API24 compatibility | ||
|
|
||
| //noinspection BomWithoutPlatform,GradleDependency | ||
| implementation platform('com.fasterxml.jackson:jackson-bom:2.13.5') //Do not upgrade! 2.13.5 is latest library with Android API24 compatibility |
There was a problem hiding this comment.
| Warning |
|
|---|---|
| 📚 | Use version catalog instead |
| 🛠️ | UseTomlInstead |
by Android Lint 🤖
| implementation platform('com.fasterxml.jackson:jackson-bom:2.13.5') //Don't upgrade from 2.13.5 due to Android API24 compatibility | ||
|
|
||
| //noinspection BomWithoutPlatform,GradleDependency | ||
| implementation platform('com.fasterxml.jackson:jackson-bom:2.13.5') //Do not upgrade! 2.13.5 is latest library with Android API24 compatibility | ||
| implementation 'com.fasterxml.jackson.core:jackson-core' |
There was a problem hiding this comment.
| Warning |
|
|---|---|
| 📚 | Use version catalog instead |
| 🛠️ | UseTomlInstead |
by Android Lint 🤖
| implementation platform('com.fasterxml.jackson:jackson-bom:2.13.5') //Don't upgrade from 2.13.5 due to Android API24 compatibility | ||
|
|
||
| //noinspection BomWithoutPlatform,GradleDependency | ||
| implementation platform('com.fasterxml.jackson:jackson-bom:2.13.5') //Do not upgrade! 2.13.5 is latest library with Android API24 compatibility | ||
| implementation 'com.fasterxml.jackson.core:jackson-core' | ||
| implementation 'com.fasterxml.jackson.core:jackson-databind' |
There was a problem hiding this comment.
| Warning |
|
|---|---|
| 📚 | Use version catalog instead |
| 🛠️ | UseTomlInstead |
by Android Lint 🤖
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.