Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MVT correct field names #928

Merged
merged 6 commits into from
Jan 15, 2025
Merged

MVT correct field names #928

merged 6 commits into from
Jan 15, 2025

Conversation

pstokkink
Copy link
Contributor

This ensures that the fields on the feature are camelCased.

  • Altered the existing test so that the expected response conforms to the schema.
  • Annotated the queryset with the camelCased field names referring to their db names.
  • Added the correct names to the tile_fields.
  • Refactored to dedupe logic.

vdboor
vdboor reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@vdboor vdboor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ziet er erg goed uit, zou klein beetje poetswerk nog doen!

pstokkink and others added 2 commits January 15, 2025 10:05
@pstokkink @vdboor
optimize check for camelcase
be9aebb 
Co-authored-by: Diederik van der Boor <vdboor@edoburu.nl>
@pstokkink
only annotate when zoom is high enough
ce3c410
@pstokkink pstokkink force-pushed the 30028-mvt-correct-field-names branch from 304d47d to ce3c410 Compare January 15, 2025 09:18
@pstokkink pstokkink merged commit c74aa0a into master Jan 15, 2025
6 checks passed
@pstokkink pstokkink deleted the 30028-mvt-correct-field-names branch January 15, 2025 11:38
@pstokkink pstokkink mentioned this pull request Jan 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdboor vdboor vdboor approved these changes

Assignees

@vdboor vdboor

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pstokkink @vdboor