Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #93: Removing unnecessary/duplicate warning #94

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Issue #93: Removing unnecessary/duplicate warning #94

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fde153
removing duplicate warning regarding no rendering (#93)
napakalas Oct 10, 2024
0d5cd48
Merge branch 'main' into issue-#93
napakalas Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions mapmaker/routing/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1434,10 +1434,6 @@ def set_direction(upstream_node):
log.warning(f'{path.id}: Path is not rendered due to partial rendering.')
route_graph.remove_nodes_from(list(route_graph.nodes))

# log a warning if no path is rendered
if len(route_graph.edges) == 0 and len(connectivity_graph.edges) > 0:
log.warning(f'{path.id}: Path is not rendered at all.')

if debug:
return (route_graph, G, connectivity_graph, terminal_graphs) # type: ignore
else:
Expand Down
Loading