Skip to content

Commit

Permalink
Trainer.train should return the best checkpoint path. It returns None. (
Browse files Browse the repository at this point in the history
#265)

This merge request fix this.

Co-authored-by: Benjamin Clavié <ben@clavie.eu>
  • Loading branch information
GeraudBourdin and bclavie authored Feb 11, 2025
1 parent 0df18e7 commit d5a38b6
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions ragatouille/models/colbert.py
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,7 @@ def train(self, data_dir, training_config: ColBERTConfig):
)

trainer.train(checkpoint=self.checkpoint)
return trainer.best_checkpoint_path()

def _colbert_score(self, Q, D_padded, D_mask):
if ColBERTConfig().total_visible_gpus > 0:
Expand Down

0 comments on commit d5a38b6

Please sign in to comment.