Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add variable dictionnary in ComponentFiller #2655

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Add variable dictionnary in ComponentFiller #2655

wants to merge 13 commits into from
+735 −203

Conversation

flomnes
Copy link
Member

@flomnes flomnes commented Feb 21, 2025 •
edited
Loading

  • Remove unused return value for VariablesBulkAddition::addVariable
  • Add wrapper around 4-key templated container. For variables, it is non-owning (raw pointers)
  • Adapt existing tests

@flomnes flomnes requested review from a-zakir and pet-mit February 21, 2025 13:28
@pet-mit pet-mit mentioned this pull request Feb 24, 2025
Merged
Base automatically changed from feature/ANT-2749 to develop February 24, 2025 14:19
@flomnes flomnes force-pushed the feature/variable-dict branch from 0200dbc to c73de2b Compare February 24, 2025 17:02
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
37 New issues
0 Accepted issues

Measures
0 Security Hotspots
69.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pet-mit pet-mit pet-mit left review comments

@a-zakir a-zakir a-zakir approved these changes

Assignees
No one assigned
Labels
Modeleur size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flomnes @a-zakir @pet-mit @payetvin