don't pause billing timer when fetching EOS VM OC's code_descriptor
#1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Jan 25, 2025
greg7mdp
approved these changes
Jan 25, 2025
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pause & restart of the billing timer occurs for every action executed by OC. It's a substantial amount of overhead (calling in to the kernel twice and doing whatever overhead needed to manage the timer) to be burdened with for every single action. I think this was added because in 1.1
consume_compile_thread_queue()is a wee bit heavier than prior releases (because it needs to take a lock a couple of times; for every action 😞 ). But since the number of outstanding compiles is limited to OC compile threads, the time spent in there is still very low. It wouldn't surprise me if this pause/resume is alone consuming more unaccounted for time than the nominal execution ofconsume_compile_thread_queue().Noticed during work of #1119