Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1.0] Test: Determine the failure of lib_advance_test using the number of unique unlinkable blocks #1174

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Feb 18, 2025

lib_advance_test checks number of unlinkable blocks in stderr.txt to decide whethere the test fails or not. It scans stderr.txt, inserts any unlinkable_block it finds into a list, and uses the number of elements in the list as the number of unlinkable blocks. But the same unlinkable block can appear in stderr.txt multiple times due to multiple connections or repeated syncing:

debug 2025-02-10T18:01:07.023 net-3     net_plugin.cpp:3967           operator()           ] unlinkable_block 174 : 000000aedde07ade58031c2926de9c9ead20c35025d53ea973e50841c71504b0, previous 173 : 000000ad3ccc782661621ba4ea215907e103efaa8fe29b737a9c7910c118fed9
...
debug 2025-02-10T18:01:07.025 net-3     net_plugin.cpp:3967           operator()           ] unlinkable_block 174 : 000000aedde07ade58031c2926de9c9ead20c35025d53ea973e50841c71504b0, previous 173 : 000000ad3ccc782661621ba4ea215907e103efaa8fe29b737a9c7910c118fed9

That causes the same unlinkable block to be counted multiple times.

The fix is to count the number of the unique unlinkable blocks.

Since the change is only limited to tests, the PR is target branch release/1.1. In order not to impact the upcoming v1.1 release, it will not be merged until v1.1 is released later this week.
It was merged into v1.1.

Resolves #1157

@linh2931 linh2931 requested review from heifner and greg7mdp February 18, 2025 15:09
@linh2931 linh2931 changed the title [1.1.x] Determine the failure of lib_advance_test using the number of unique unlinkable blocks [1.1.x] Test: Determine the failure of lib_advance_test using the number of unique unlinkable blocks Feb 18, 2025
@linh2931 linh2931 merged commit 1c288b6 into release/1.1 Feb 18, 2025
36 checks passed
@linh2931 linh2931 deleted the lib_advance_test_fix branch February 18, 2025 22:16
@linh2931 linh2931 changed the title [1.1.x] Test: Determine the failure of lib_advance_test using the number of unique unlinkable blocks [1.1.0] Test: Determine the failure of lib_advance_test using the number of unique unlinkable blocks Feb 18, 2025
@ericpassmore
Copy link
Contributor

Note:start
category: Tests
component: Internal
summary: Count the number of the unique unlinkable blocks in lib_advance_test
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants