[1.1.0] Test: Determine the failure of lib_advance_test using the number of unique unlinkable blocks #1174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib_advance_test
checks number of unlinkable blocks instderr.txt
to decide whethere the test fails or not. It scansstderr.txt
, inserts anyunlinkable_block
it finds into a list, and uses the number of elements in the list as the number of unlinkable blocks. But the same unlinkable block can appear instderr.txt
multiple times due to multiple connections or repeated syncing:That causes the same unlinkable block to be counted multiple times.
The fix is to count the number of the unique unlinkable blocks.
Since the change is only limited to tests, the PR is target branchrelease/1.1
. In order not to impact the upcomingv1.1
release, it will not be merged untilv1.1
is released later this week.It was merged into
v1.1
.Resolves #1157