Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SC: SYNC_CALL protocol feature definition and registration #1222

Merged
merged 7 commits into from
Mar 3, 2025
Merged

SC: SYNC_CALL protocol feature definition and registration #1222

merged 7 commits into from
Mar 3, 2025

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Feb 28, 2025 •
edited
Loading

  • Define and register SYNC_CALL protocol feature.
  • Add a test to verify the definition is correct, dependency is met, and SYNC_CALL can be activated.
  • Fix a fragility of former preactivate_all_but_disable_deferred_trx such that no code changes are required when future protocol features are added
  • Rename full_except_do_not_disable_deferred_trx to full_prior_to_disable_deferred_trx and preactivate_all_but_disable_deferred_trx to preactivate_all_prior_to_disable_deferred_trx to better reflect what they are.

Resolves #1212.

@linh2931
Update deep-mind test log
568a244
@linh2931
Update test data for savanna_misc_tests/verify_block_compatibitity
514f9a5
@linh2931
Fix fragile of base_tester::preactivate_all_but_disable_deferred_trx(…
a8786ce 
…) when a new protocol feature is tested
@linh2931
Rename setup_policy::full_except_do_not_disable_deferred_trx to setup…
b52d2d4 
…_policy::full_prior_to_disable_deferred_trx, validating_tester_no_disable_deferred_trx to validating_tester_no_disable_deferred_trx so they better reflect what they are
@ericpassmore
Copy link
Contributor

Note:start
category: Other
component: Contracts
summary: Define and register SYNC_CALL protocol feature.
Note:end

@linh2931 linh2931 merged commit 62bef0e into sync_call Mar 3, 2025
36 checks passed
@linh2931 linh2931 deleted the sync_call_protocol_feature branch March 3, 2025 19:53
@linh2931 linh2931 linked an issue Mar 4, 2025 that may be closed by this pull request
SC: Introduce sync_call Protocol Feature #1212
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

@spoonincode spoonincode spoonincode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SC: Introduce sync_call Protocol Feature
4 participants
@linh2931 @ericpassmore @heifner @spoonincode