-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect Apama, fix up settings, use stdio LSP, miscellaneous cleanup #63
Draft
bph-c8y
wants to merge
22
commits into
master
Choose a base branch
from
dev/apama-detection
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve our ability to find Apama processes on the system.
- Default apamahome assumed Windows. - Various descriptions implied the set value was the default, which is obviously not true if it is configurable. - Remove option for a "Remote" language server: while it currently works, it will soon be removed, and is antithetical to how MS expect you to run a Language Server.
VSCode automatically parses camel case names to be separate words.
We're going to use this to gate all advanced functionality.
Also, some renaming of things to less generic names.
- Remove all networking artifacts. - Let the Language Client handle spawning the process (and thus, process cleanup). - Remove language server networking configuration options. - Remove all process cleanup code, and associated libraries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: