c improvements #82
Merged
c improvements #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
prabhu
commented
Jul 9, 2024
| f2.signature shouldBe "void A.f (char)" | ||
| foo.fullName shouldBe "foo" | ||
| bar.fullName shouldBe "bar" | ||
| f1.fullName shouldBe "A.f:void(int)" |
There was a problem hiding this comment.
An example of the improvements.
prabhu
commented
Jul 9, 2024
| cpg.method.fullName("Cat.eat").caller.fullName.toSet shouldBe Set("main") | ||
| cpg.method.fullName("Animal.eat").caller.fullName.toSet shouldBe Set("People.feedPets", "main") | ||
| cpg.method.name("eat").fullName.toSet shouldBe Set("Animal.eat:void()", "Cat.eat:void()", "People.eat:void()") | ||
| cpg.method.name("main").callee.fullName.toSet shouldBe Set("Animal.eat:void()", "Cat.eat:void()", "<operator>.addressOf") |
There was a problem hiding this comment.
This is actually a bug since Animal.eat is never called from main. But this is for another day.
prabhu
commented
Jul 9, 2024
| @@ -124,32 +124,32 @@ class AstCreationPassTests extends AbstractPassTest { | |||
| inside(cpg.method.fullNameExact(lambda1FullName).l) { case List(l1) => | |||
| l1.name shouldBe lambda1FullName | |||
| l1.code should startWith("[] (int a, int b) -> int") | |||
| l1.signature shouldBe "int anonymous_lambda_0 (int,int)" | |||
| l1.signature shouldBe "int (int,int)" | |||
There was a problem hiding this comment.
Function and lambda names are removed from the signature.
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings numerous improvements to full names and signature from upstream.