Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default dimensions for OTEL metrics #19

Merged
merged 5 commits into from
Feb 11, 2025
Merged

Conversation

bprotopopov
Copy link
Contributor

This allows one to add a number of custom dimensions to the published metrics. This may be necessary in order to analyze metrics along various dimensions, e.g. when exporting metrics to CloudWatch.

@evg-tso
Copy link
Member

evg-tso commented Dec 1, 2024

Thanks for the contribution @bprotopopov!
I've pushed an update to the CI to be able to verify PRs from forks.
Can you please rebase?

@bprotopopov
Copy link
Contributor Author

Hi, @evg-tso, thanks for the quick response, rebased.

Copy link

github-actions bot commented Dec 12, 2024

Test Results

8 files  8 suites   4s ⏱️
1 tests 1 ✅ 0 💤 0 ❌
8 runs  8 ✅ 0 💤 0 ❌

Results for commit 095fe46.

♻️ This comment has been updated with latest results.

@evg-tso
Copy link
Member

evg-tso commented Dec 12, 2024

Awesome, now we just need to update the project.clj and the CHANGELOG.md.
Would you be able to bump to 1.1.0 as this is technically a new feature and update the CHANGELOG similarly to this? (Meaning adding a 1.1.0 section which is linking to this PR?

@bprotopopov
Copy link
Contributor Author

@bprotopopov
Copy link
Contributor Author

Hi, I am looking at the requested changes in CHANGELOG.md, and it appears that the diffs section at the bottom can only be added once the pull request is accepted (the diffs refer to changes in the AppsFlyer/aws-sdk-java-opentelemetry-metrics repo)? I am not clear on how I could add those/refer to them in my pull request. Also, I cannot find file project.clj in the repo, or any references to the file in the pull 18 example you refer to above.

Can you please clarify what I need to do?

@bprotopopov
Copy link
Contributor Author

Ping. Please let me know how I can help with releasing the change.

@evg-tso
Copy link
Member

evg-tso commented Feb 10, 2025

Sorry for the delay.

Also, I cannot find file project.clj in the repo.

Sorry again!
I was thinking of another project and got confused. I meant the pom.xml.

Can you please clarify what I need to do?

  1. Add this to the CHANGELOG.md
## [1.1.0] - 2025-02-10

### Added

- Add default dimensions for OTEL metrics.


(Somewhere below..)


[1.1.0]: https://github.com/AppsFlyer/aws-sdk-java-opentelemetry-metrics/compare/aws-sdk-java-opentelemetry-metrics-1.0.1...aws-sdk-java-opentelemetry-metrics-1.1.0
  1. Update the version in pom.xml:
<version>1.1.0-SNAPSHOT</version>

@evg-tso
Copy link
Member

evg-tso commented Feb 10, 2025

If you don't mind, I can push to your branch

@bprotopopov
Copy link
Contributor Author

bprotopopov commented Feb 10, 2025 via email

@evg-tso evg-tso merged commit 0803e4c into AppsFlyer:main Feb 11, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants