docs: 이설희 자기소개 추가 #157
Closed
docs: 이설희 자기소개 추가 #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D0ri123
requested review from
Jack-R-lantern,
sunyeongchoi and
shmruin
as code owners
Signed-off-by: D0ri123 <lsh81550@gmail.com>
Jack-R-lantern
requested changes
Jul 20, 2024
Signed-off-by: D0ri123 <lsh81550@gmail.com>
|
https://github.com/Argo-OSS/beginner-guide/blob/main/common/02-gpg.md commit에 gpg sign을 넣어주세요 |
Signed-off-by: D0ri123 <lsh81550@gmail.com>
|
gpg sign을 넣는게 어려우면 질문해주세요 |
앗 signed-off-by만 붙이면 되는 건줄 알았는데, gpg 키 생성한 커밋은 Verified가 붙는 거였네요 ㅎ |
|
네 그렇게 진행해도 좋고 rebase를 통해 squash를 진행하면서 추가해도 됩니다 |
|
하다가 꼬이게 되어서 새로운 PR 올려뒀습니다~! PR #160 참고해주시면 감사하겠습니다..! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #155