feat: junseok's container #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junseokee
requested review from
Jack-R-lantern,
sunyeongchoi and
shmruin
as code owners
Jack-R-lantern
requested changes
Jul 26, 2024
There was a problem hiding this comment.
Service 부분에 Selector 작성이 누락되어서
현재 Test에서 Service 탐지를 못하고 있어요.
Service에 Selector만 추가하면 될것 같습니다
There was a problem hiding this comment.
그리고 commit에 sign off 누락된것들 다 충족하면 될것 같습니다.
Jack-R-lantern
requested changes
Jul 26, 2024
There was a problem hiding this comment.
Multi Stage Build를 이용해 잘 구성한것 같아요.
다만 Cache Hit를 고려해서 Layer를 수정해보는건 어떨까요?
해당 부분은 치명적 이슈는 아니어서 수정해도 좋고 안해도 좋습니다.
There was a problem hiding this comment.
넵 관련 레퍼런스 조금 더 참고해서 수정 해보겠습니다 !
조언 감사드립니다 !
Junseokee
force-pushed
the
main
branch
2 times, most recently
from
8bc12d4 to
8fd4a30
Compare
Signed-off-by: Junseokee <weq156@naver.com>
Signed-off-by: Junseokee <weq156@naver.com>
Signed-off-by: Junseokee <weq156@naver.com>
Signed-off-by: Junseokee <weq156@naver.com>
Signed-off-by: Junseokee <weq156@naver.com>
Signed-off-by: Junseokee <weq156@naver.com>
Signed-off-by: Junseokee <weq156@naver.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #40