Skip to content

Commit

Permalink
Fix unix builds
Browse files Browse the repository at this point in the history
Unnecessary use of std::move.
  • Loading branch information
JGamache-autodesk committed Dec 6, 2022
1 parent f6097b4 commit 9aa3f72
Showing 1 changed file with 8 additions and 12 deletions.
20 changes: 8 additions & 12 deletions lib/mayaUsd/ufe/UsdUndoConnectionCommands.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,8 @@ UsdUndoCreateConnectionCommand::UsdUndoCreateConnectionCommand(
const Ufe::Attribute::Ptr& srcAttr,
const Ufe::Attribute::Ptr& dstAttr)
: Ufe::ConnectionResultUndoableCommand()
, _srcInfo(std::move(std::make_unique<Ufe::AttributeInfo>(srcAttr))
, _dstInfo(std::move(std::make_unique<Ufe::AttributeInfo>(dstAttr))
, _srcInfo(std::make_unique<Ufe::AttributeInfo>(srcAttr))
, _dstInfo(std::make_unique<Ufe::AttributeInfo>(dstAttr))
{
// Validation goes here when we find out the right set of business rules. Failure should result
// in a exception being thrown.
Expand Down Expand Up @@ -261,18 +261,16 @@ Ufe::Connection::Ptr UsdUndoCreateConnectionCommand::connection() const
}
}

void UsdUndoCreateConnectionCommand::undo() {
_undoableItem.undo(); }
void UsdUndoCreateConnectionCommand::undo() { _undoableItem.undo(); }

void UsdUndoCreateConnectionCommand::redo() {
_undoableItem.redo(); }
void UsdUndoCreateConnectionCommand::redo() { _undoableItem.redo(); }

UsdUndoDeleteConnectionCommand::UsdUndoDeleteConnectionCommand(
const Ufe::Attribute::Ptr& srcAttr,
const Ufe::Attribute::Ptr& dstAttr)
: Ufe::UndoableCommand()
, _srcInfo(std::move(std::make_unique<Ufe::AttributeInfo>(srcAttr))
, _dstInfo(std::move(std::make_unique<Ufe::AttributeInfo>(dstAttr))
, _srcInfo(std::make_unique<Ufe::AttributeInfo>(srcAttr))
, _dstInfo(std::make_unique<Ufe::AttributeInfo>(dstAttr))
{
// Validation goes here when we find out the right set of business rules. Failure should result
// in a exception being thrown.
Expand Down Expand Up @@ -336,11 +334,9 @@ void UsdUndoDeleteConnectionCommand::execute()
}
}

void UsdUndoDeleteConnectionCommand::undo() {
_undoableItem.undo(); }
void UsdUndoDeleteConnectionCommand::undo() { _undoableItem.undo(); }

void UsdUndoDeleteConnectionCommand::redo() {
_undoableItem.redo(); }
void UsdUndoDeleteConnectionCommand::redo() { _undoableItem.redo(); }

} // namespace ufe
} // namespace MAYAUSD_NS_DEF

0 comments on commit 9aa3f72

Please sign in to comment.