Add Blob Copy & Page Blob support to by SQL based metadata implementation in Blob API and Sync Loki and SQL metadata stores #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rializing de-serializing of remaining properties as well.
…n SQL blobMetadataStore
…nd on timezone and fails even then and test another component not Azurite
…container test since now it is working
…tests to be flaky
mahmoudbahaa
changed the title
blueww
reviewed
Oct 25, 2023
| it(`Should work with production style URL when ${productionStyleHostName} is resolvable`, async () => { | ||
| // This now doesn't work (Error: Unable to extract accountName with provided information.). | ||
| // As the sdk expect an url in the form devstoreaccount1.blob.localhost instead of devstoreaccount1.localhost | ||
| it.skip(`Should work with production style URL when ${productionStyleHostName} is resolvable`, async () => { |
There was a problem hiding this comment.
This looks already won't run as don't have loki or sql tag, so looks don't need skip it.
blueww
reviewed
Dec 26, 2023
| @@ -488,8 +488,6 @@ This feature is in preview, when Azurite changes database table schema, you need | |||
|
|
|||
| > Note. Need to manually create database before starting Azurite instance. | |||
|
|
|||
| > Note. Blob Copy & Page Blob are not supported by SQL based metadata implementation. | |||
|
|
|||
There was a problem hiding this comment.
The support matrix section in ReadMe.md should also be updated.
Line 1011 in 9208664
blueww
reviewed
Dec 27, 2023
| contentProperties: { | ||
| type: "VARCHAR(1023)" | ||
| properties: { | ||
| type: "VARCHAR(4095)" |
There was a problem hiding this comment.
Will this cause the saved blobs in old Azurite version, can't be read out with new Azurite version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Blob Copy & Page Blob support to by SQL based metadata implementation in Blob API. This makes the SQL based metadata implementation in sync with File based one. (issue #2224)
I divided the PR into very small mini commits for better visibility but most of these commits are small either in scope or code.
Changes are as follows:
In code: ([SqlBlobMetadataStore.ts])
copyFromURLfrom Loki to SQL blobMeatadataStoreappendBlockfrom Loki to SQL blobMeatadataStoreclearRangefrom Loki to SQL blobMeatadataStoregetPageRangesfrom Loki to SQL blobMeatadataStoreresizePageBlobfrom Loki to SQL blobMeatadataStoreupdateSequenceNumberfrom Loki to SQL blobMeatadataStoreIn Tests:
generateAccountSASQueryParametersin sas blob tests as it depend on timezone and fails even then and test another component not AzuriteOthers:
Note: I recommend removing the @loki and @SQL all together and run all test cases without grep for both loki and sql to avoid descync in the future but its your call.