Fix waagent overriding SSH public key from Ignition configuration #3307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kevin Clark <kevin.clark@microsoft.com>
Merge hotfix-2.3.1 into master
…e#2349) Co-authored-by: Laveesh Rohra <larohra@microsoft.com>
Azure#2358) * Use handler status if extension status is None when computing the ExtensionsSummary * Add NotReady to convergence statuses Co-authored-by: narrieta <narrieta>
Merge release-2.4.0.0 into master
* define ExtensionsSummary.__eq__ * Fix test name * Fix test name * Fix test name Co-authored-by: narrieta <narrieta>
Co-authored-by: narrieta <narrieta>
* Improve error message for vmSettings errors * Add etag and correlation id * pylint warning Co-authored-by: narrieta <narrieta>
Azure#2404) Co-authored-by: narrieta <narrieta>
Merge release 2.5.0.0 into master
* Set Agent version to 2.7.0.0 * Remove duplicate import Co-authored-by: narrieta <narrieta>
* Simplify the logic to update the extensions goal state * Added telemetry for NotSupported * Added comments * Do not support old hostgaplugin Co-authored-by: narrieta <narrieta>
(cherry picked from commit 4dcf95c)
…ctor and remove fiirewall daemon-reload (Azure#3223) (Azure#3226) * move daemon reload * test fix * UT test * firewall daemon-reload * address comments * address comments (cherry picked from commit 47e969a)
* Update ubuntu 24 * Add ubuntu 24 to nat clouds * Add arm64 ubuntu 24 * Update all ubuntu images * Skip arm64 in nat clouds * Fix syntax issues (cherry picked from commit 31adf25)
Merge Hotfix 2.11.1.9 (2.11.1.12) to master
Release 2.12.0.0 to master
(cherry picked from commit 7cbde8b) Co-authored-by: Nageswara Nandigam <84482346+nagworld9@users.noreply.github.com>
(cherry picked from commit 5a94b1e) Co-authored-by: Nageswara Nandigam <84482346+nagworld9@users.noreply.github.com>
Hotfix 2.12.0.4 to master
peytonr18
requested review from
narrieta,
ZhidongPeng,
nagworld9 and
maddieford
as code owners
|
@ZhidongPeng this looks good to me. This problem is causing serious grief for at least one flatcar customer, and the flatcar team is ready and able to do the integration work to update the waagent in their Azure VM images. They really don't want to fork the agent to get their customer unstuck. |
|
Hi @peytonr18 , Changes lgtm but can you please update the PR to merge into develop. We don't merge changes directly into master. Thank you |
|
Will delete this PR -- should have made the fix and based my PR on develop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves an issue where the WALinuxAgent overrides the SSH public key provided by Ignition configuration during provisioning. The issue is related to this ongoing ICM, and applies the fix given for resolving the issue.
Issue #
PR information
developbranch.Quality of Code and Contribution Guidelines