Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ext dependencies scenarios to share scaleset #3312

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

maddieford
Copy link
Contributor

Description

Issue #


PR information

  • Ensure development PR is based on the develop branch.
  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.61%. Comparing base (3aebcdd) to head (497180f).
Report is 358 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3312      +/-   ##
===========================================
+ Coverage    71.97%   72.61%   +0.63%     
===========================================
  Files          103      114      +11     
  Lines        15692    17164    +1472     
  Branches      2486     2296     -190     
===========================================
+ Hits         11295    12464    +1169     
- Misses        3881     4146     +265     
- Partials       516      554      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

narrieta
narrieta previously approved these changes Jan 31, 2025
# Disable policy via conf file and delete policy file.
for ssh_client in ssh_clients.values():
ssh_client.run_command("update-waagent-conf Debug.EnableExtensionPolicy=n", use_sudo=True)
ssh_client.run_command("rm -f /etc/waagent_policy.json", use_sudo=True)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a log message here that policy has been turned off?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@maddieford maddieford merged commit 753d797 into Azure:develop Feb 4, 2025
11 checks passed
@maddieford maddieford deleted the cleanup_dependencies branch February 4, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants