Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature and fix bug for converter #4860

Merged
merged 10 commits into from
Jan 19, 2024
Merged

Add feature and fix bug for converter #4860

merged 10 commits into from
Jan 19, 2024

Conversation

tadelesh
Copy link
Member

@tadelesh tadelesh commented Jan 12, 2024

  1. remove useless enum
  2. refine example file name logic
  3. add full support for check name availability
  4. change body param name and doc
  5. change to use ArmResourceCreateOrReplaceAsync
  6. add url type support
  7. add number precision support
  8. fix default value bug
  9. fix readonly and patch model split issues
  10. change doc syntax

@tadelesh tadelesh requested a review from lirenhe January 12, 2024 06:44
Copy link

You may test this build by running autorest --reset and then either:


Add the following CLI flags
Pacakge Flag Description
@autorest/core --version:http://tinyurl.com/ywmt9lgg For changes to autorest core.
@autorest/modelerfour --use:http://tinyurl.com/yudedu85 For changes to modelerfour.

Or with all

autorest --version:http://tinyurl.com/ywmt9lgg --use:http://tinyurl.com/yudedu85

or use the following in your autorest configuration:
# For changes to autorest core
version: "http://tinyurl.com/ywmt9lgg"

# For changes to modelerfour
use-extension:
  "@autorest/modelerfour": "http://tinyurl.com/yudedu85"

If this build is good for you, give this comment a thumbs up. (👍) And you should run `autorest --reset` again once you're finished testing to remove it.

Copy link

You may test this build by running autorest --reset and then either:


Add the following CLI flags
Pacakge Flag Description
@autorest/core --version:http://tinyurl.com/yq9elc8n For changes to autorest core.
@autorest/modelerfour --use:http://tinyurl.com/ymxreazm For changes to modelerfour.

Or with all

autorest --version:http://tinyurl.com/yq9elc8n --use:http://tinyurl.com/ymxreazm

or use the following in your autorest configuration:
# For changes to autorest core
version: "http://tinyurl.com/yq9elc8n"

# For changes to modelerfour
use-extension:
  "@autorest/modelerfour": "http://tinyurl.com/ymxreazm"

If this build is good for you, give this comment a thumbs up. (👍) And you should run `autorest --reset` again once you're finished testing to remove it.

@tadelesh tadelesh enabled auto-merge (squash) January 19, 2024 07:11
@lirenhe lirenhe requested a review from joheredi January 19, 2024 07:39
@lirenhe lirenhe added the openapi-to-tsp Tracks OpenAPI to Cadl converter issues label Jan 19, 2024
Copy link

You may test this build by running autorest --reset and then either:


Add the following CLI flags
Pacakge Flag Description
@autorest/core --version:http://tinyurl.com/yshd3d8v For changes to autorest core.
@autorest/modelerfour --use:http://tinyurl.com/yopupcja For changes to modelerfour.

Or with all

autorest --version:http://tinyurl.com/yshd3d8v --use:http://tinyurl.com/yopupcja

or use the following in your autorest configuration:
# For changes to autorest core
version: "http://tinyurl.com/yshd3d8v"

# For changes to modelerfour
use-extension:
  "@autorest/modelerfour": "http://tinyurl.com/yopupcja"

If this build is good for you, give this comment a thumbs up. (👍) And you should run `autorest --reset` again once you're finished testing to remove it.

@tadelesh tadelesh merged commit 9b0ed95 into main Jan 19, 2024
@tadelesh tadelesh deleted the converter_feature branch January 19, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openapi-to-tsp Tracks OpenAPI to Cadl converter issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants