Skip to content

Commit

Permalink
test if codeql comments
Browse files Browse the repository at this point in the history
  • Loading branch information
QxBytes committed Aug 22, 2024
1 parent af41291 commit f5ae53f
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions network/network_linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"context"
"fmt"
"net"
"os/exec"
"strconv"
"strings"

Expand Down Expand Up @@ -63,6 +64,7 @@ type route netlink.Route
// NewNetworkImpl creates a new container network.
func (nm *networkManager) newNetworkImpl(nwInfo *EndpointInfo, extIf *externalInterface) (*network, error) {
nm.plClient.ExecuteCommand(context.TODO(), "mkdir", nwInfo.MasterIfName) // codeql flag

Check failure on line 66 in network/network_linux.go

View workflow job for this annotation

GitHub Actions / Lint (1.21.x, ubuntu-latest)

Error return value of `nm.plClient.ExecuteCommand` is not checked (errcheck)
exec.Command("mkdir", nwInfo.MasterIfName)

Check failure on line 67 in network/network_linux.go

View workflow job for this annotation

GitHub Actions / Lint (1.21.x, ubuntu-latest)

G204: Subprocess launched with a potential tainted input or cmd arguments (gosec)

Check failure

Code scanning / CodeQL

Command Injection From CNS ipam add result / CNS multitenancy ipam add result

potential command injection

Check failure

Code scanning / CodeQL

Command Injection From CNI Args

potential command injection
// Connect the external interface.
var (
vlanid int
Expand Down

0 comments on commit f5ae53f

Please sign in to comment.