Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC Server Implementation #2758

Closed
wants to merge 6 commits into from

Conversation

Kevincxv
Copy link
Contributor

Reason for Change:

Issue Fixed:

Requirements:

Notes:

@Kevincxv Kevincxv requested a review from debecerra May 30, 2024 20:27
@Kevincxv Kevincxv changed the title CNS gRPC Server Implementation gRPC Server Implementation May 31, 2024
@timraymond
Copy link
Member

@Kevincxv Is this different from #2745 ? If not, it's better to keep things in one PR to keep the discussion organized.

@debecerra
Copy link
Contributor

@timraymond This PR is going to cover a feature that builds on top of #2745, so #2745 isn't going anywhere. This draft PR is up for visibility on the new code changes and to avoid being blocked on the review process for the prerequisite PR

@timraymond
Copy link
Member

@debecerra Gotcha. Can we rebase it off of that branch instead of master so that way only the diffs from this work are present? That would resolve the confusion and at least make it easy to see what changed here alone.

@rbtr
Copy link
Contributor

rbtr commented May 31, 2024

@debecerra Gotcha. Can we rebase it off of that branch instead of master so that way only the diffs from this work are present? That would resolve the confusion and at least make it easy to see what changed here alone.

+1 rebase it on the branch in that PR instead of master, and change the target branch on this PR to that branch also. Then the diff here will only be the changes added on top of that PR. Change both back to master after that PR is completed.

@debecerra debecerra changed the base branch from master to Kevin-CNS-gRPC May 31, 2024 21:05
@Kevincxv Kevincxv closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants