Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prefix length from mtpnc to podipinfo & gatewayip #2828

Merged
merged 9 commits into from
Jul 10, 2024

Conversation

kmurudi
Copy link
Contributor

@kmurudi kmurudi commented Jul 3, 2024

Reason for Change:

AKS Middleware for Swiftv2 requires us to add the correct subnet-prefix length which was missing & set the gateway IP as well in CNS for pod connectivity to work.

Issue Fixed:

Requirements:

Notes:

@kmurudi kmurudi requested a review from a team as a code owner July 3, 2024 08:18
@kmurudi kmurudi requested a review from ashvindeodhar July 3, 2024 08:18
@kmurudi kmurudi force-pushed the SubnetAddressSpace_K8sSwiftv2 branch from a164ec8 to 256d1d3 Compare July 4, 2024 02:20
@kmurudi
Copy link
Contributor Author

kmurudi commented Jul 4, 2024

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulyufan2
Copy link
Contributor

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

paulyufan2
paulyufan2 previously approved these changes Jul 4, 2024
@paulyufan2 paulyufan2 enabled auto-merge July 4, 2024 19:07
@paulyufan2
Copy link
Contributor

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Kshitija Murudi <kmurudi@microsoft.com>
Copy link
Contributor

@thatmattlong thatmattlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is too much copy/pasted between the linux and windows versions. Let's keep one common function for the majority of the code, and then create windows/linux versions only for the part that is different.

cns/middlewares/k8sSwiftV2_windows.go Outdated Show resolved Hide resolved
cns/middlewares/k8sSwiftV2_windows.go Outdated Show resolved Hide resolved
@kmurudi
Copy link
Contributor Author

kmurudi commented Jul 9, 2024

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kmurudi kmurudi force-pushed the SubnetAddressSpace_K8sSwiftv2 branch from 02fca1e to f4185ac Compare July 9, 2024 21:36
@kmurudi
Copy link
Contributor Author

kmurudi commented Jul 9, 2024

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulyufan2 paulyufan2 added this pull request to the merge queue Jul 9, 2024
Merged via the queue into master with commit e3b25da Jul 10, 2024
11 checks passed
@paulyufan2 paulyufan2 deleted the SubnetAddressSpace_K8sSwiftv2 branch July 10, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants