fetch primary mac for hns accelnet #2857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulyufan2
reviewed
Jul 17, 2024
kmurudi
force-pushed
the
Accelnet_HNS_Mac
branch
from
89fbcf5 to
eebf383
Compare
paulyufan2
reviewed
Jul 18, 2024
kmurudi
force-pushed
the
Accelnet_HNS_Mac
branch
2 times, most recently
from
0df01a9 to
3776003
Compare
paulyufan2
force-pushed
the
Accelnet_HNS_Mac
branch
3 times, most recently
from
6e83fe8 to
bfa090f
Compare
kmurudi
force-pushed
the
Accelnet_HNS_Mac
branch
from
bfa090f to
d2220e1
Compare
paulyufan2
reviewed
Jul 25, 2024
kmurudi
force-pushed
the
Accelnet_HNS_Mac
branch
2 times, most recently
from
4433dbf to
7d61a27
Compare
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nddq
reviewed
Jul 26, 2024
kmurudi
force-pushed
the
Accelnet_HNS_Mac
branch
from
3b6feb8 to
6595042
Compare
fix fmt issues, linter
kmurudi
force-pushed
the
Accelnet_HNS_Mac
branch
2 times, most recently
from
71256d7 to
2ffda8b
Compare
kmurudi
force-pushed
the
Accelnet_HNS_Mac
branch
from
2ffda8b to
6089e56
Compare
nddq
approved these changes
Jul 30, 2024
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
swiftv2 for windows requires to send HNS the primary mac address on the vm where accelerated networking is enabled. we have chosen to do this on the startup of cns service as it is a one-time operation before serving requests for pod/container creation.
This hns api will set VF (virtual functions) feature for all of the accelnet-nics on the VM (all except primary nic) & be a no-op on others if they are not accelnet-enabled nics.
Issue Fixed:
Requirements:
Notes: