Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UTs to configure secondary interfaces add Result for windows swiftv2 #2923

Merged
merged 12 commits into from
Aug 23, 2024

Conversation

paulyufan2
Copy link
Contributor

Reason for Change:

This PR is to add UTs to configure secondary interfaces add Result for windows swiftv2

Issue Fixed:

Requirements:

Notes:

@paulyufan2 paulyufan2 added the cni Related to CNI. label Aug 15, 2024
@paulyufan2 paulyufan2 requested a review from QxBytes August 15, 2024 18:40
@paulyufan2 paulyufan2 requested review from a team as code owners August 15, 2024 18:40
@paulyufan2 paulyufan2 requested a review from jaer-tsun August 15, 2024 18:40
@paulyufan2
Copy link
Contributor Author

/azp run Azure Container Networking PR

@paulyufan2 paulyufan2 enabled auto-merge August 15, 2024 19:28
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

cni/network/invoker_cns_test.go Outdated Show resolved Hide resolved
cni/network/network.go Outdated Show resolved Hide resolved
cni/network/network_windows_test.go Outdated Show resolved Hide resolved
@paulyufan2 paulyufan2 force-pushed the addResultUTs branch 2 times, most recently from fce6a75 to e775594 Compare August 20, 2024 14:36
@paulyufan2
Copy link
Contributor Author

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

cni/network/network_windows_test.go Outdated Show resolved Hide resolved
cni/network/network.go Outdated Show resolved Hide resolved
QxBytes
QxBytes previously approved these changes Aug 20, 2024
tamilmani1989
tamilmani1989 previously approved these changes Aug 22, 2024
@paulyufan2
Copy link
Contributor Author

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulyufan2 paulyufan2 added this pull request to the merge queue Aug 22, 2024
@paulyufan2 paulyufan2 removed this pull request from the merge queue due to a manual request Aug 22, 2024
@paulyufan2 paulyufan2 added this pull request to the merge queue Aug 22, 2024
@paulyufan2 paulyufan2 removed this pull request from the merge queue due to a manual request Aug 22, 2024
@paulyufan2
Copy link
Contributor Author

/azp run Azure Container Networking PR

@paulyufan2 paulyufan2 enabled auto-merge August 22, 2024 20:36
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulyufan2 paulyufan2 added this pull request to the merge queue Aug 22, 2024
@paulyufan2 paulyufan2 removed this pull request from the merge queue due to a manual request Aug 22, 2024
Signed-off-by: Paul Yu <129891899+paulyufan2@users.noreply.github.com>
@paulyufan2 paulyufan2 dismissed stale reviews from QxBytes and tamilmani1989 via ada27b9 August 22, 2024 22:58
@paulyufan2
Copy link
Contributor Author

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulyufan2 paulyufan2 enabled auto-merge August 22, 2024 23:14
@paulyufan2 paulyufan2 added this pull request to the merge queue Aug 22, 2024
Merged via the queue into master with commit 4c66f48 Aug 23, 2024
11 checks passed
@paulyufan2 paulyufan2 deleted the addResultUTs branch August 23, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cni Related to CNI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants