Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] feat: add PodNetwork and WorkloadNetworkConfig in acn.azure.com CRD scheme #2946

Closed
wants to merge 3 commits into from
Closed

[WIP] feat: add PodNetwork and WorkloadNetworkConfig in acn.azure.com CRD scheme #2946

wants to merge 3 commits into from

Conversation

isaac-dasan
Copy link
Member

@isaac-dasan isaac-dasan commented Aug 21, 2024 •
edited
Loading

Reason for Change:
New CRD schema for GA readiness of swiftv2.

Notes:

  • Adding a new CRD workloadNetworkConfig (WNC) in acn.azure.com to replace PNI in multitenancy.acn.azure.com, since bumping to v1beta1 in multitenancy.acn.azure.com needs a new conversion webhook which might take a lot of cycles.
  • WNC has new properties for supporting routing config and makes WNC partly mutable. The status is also slightly different from that of PNI - now there is a WNC status (ready or notready) and a status corresponding to each podnetworkconfig.
  • Moving WNC and PN to acn.azure.com (from multitenancy.acn.azure.com) is due to the fact that these CRDs will also be used in single tenancy scenarios.
  • The PN spec will be mutable, removed deprecated VnetGuid and made NetworkGuid and DeviceType as required propertie

@isaac-dasan isaac-dasan requested a review from a team as a code owner August 21, 2024 21:28
@isaac-dasan isaac-dasan requested a review from neaggarwMS August 21, 2024 21:28
@isaac-dasan isaac-dasan force-pushed the isaac/swiftv2/crd/workloadNetworkConfig branch from 1fef33f to 7c91776 Compare August 21, 2024 22:41
@isaac-dasan isaac-dasan changed the title feat: add PodNetwork and WorkloadNetworkConfig in acn.azure.com CRD scheme [WIP] feat: add PodNetwork and WorkloadNetworkConfig in acn.azure.com CRD scheme Aug 21, 2024
@isaac-dasan
Add PodNetwork and WorkloadNetworkConfig in acn.azure.com CRD scheme
776f128 
Signed-off-by: GitHub <noreply@github.com>
@isaac-dasan
add deprecation warning
97d1e60 
Signed-off-by: GitHub <noreply@github.com>
@isaac-dasan
Fix go lint errors
a463968 
Signed-off-by: GitHub <noreply@github.com>
@isaac-dasan isaac-dasan force-pushed the isaac/swiftv2/crd/workloadNetworkConfig branch from 7c91776 to a463968 Compare August 22, 2024 18:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Sep 6, 2024
@github-actions GitHub Actions
Copy link

Pull request closed due to inactivity.

@github-actions github-actions bot closed this Sep 13, 2024
@github-actions github-actions bot deleted the isaac/swiftv2/crd/workloadNetworkConfig branch September 13, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neaggarwMS neaggarwMS Awaiting requested review from neaggarwMS neaggarwMS is a code owner automatically assigned from Azure/azure-sdn-members

@thatmattlong thatmattlong Awaiting requested review from thatmattlong

Assignees
No one assigned
Labels
stale Stale due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@isaac-dasan