Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: ci: run some cni windows uts in the pipeline (#2925) #2962

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

QxBytes
Copy link
Contributor

@QxBytes QxBytes commented Aug 27, 2024

Reason for Change:

Backports #2925

cherry pick files to mock hns v2

modify multitenancy cni tests to reflect 1.5.x behavior (changes to be applied only to 1.5.x as behavior differs in 1.6.x):

- updates mock network manager to use the network id passed in
- updates mock network manager to get all endpoint infos based on a network id
- updates mock network manager find network id from net ns to reflect dualnic get network id behavior
(gets multiple networks because on deletion, you have one less endpoint that matches the netns/netnspath, and so use the network id of the other endpoint for deletion)
- updates windows tests to use eth1 to avoid mock endpoint client from throwing a duplicate endpoint id error
- separates windows and linux multitenancy tests because their behavior is different
- updates windows unit tests to allow passing in an expected num of endpoints for EACH network id after EACH command is run during delete test

Issue Fixed:

Requirements:

Notes:

QxBytes and others added 3 commits August 23, 2024 11:57
* make windows uts pass

* separate multitenancy uts for windows into platform specific file

* move ut testing to separate template

* address linter issue

* run windows platform tests

* revert removing test create bridge

* remove parameter from ut template
@QxBytes QxBytes self-assigned this Aug 27, 2024
@QxBytes QxBytes added cni Related to CNI. ci Infra or tooling. release/1.5 Change affects v1.5 release train labels Aug 27, 2024
- updates mock network manager to use the network id passed in
- updates mock network manager to get all endpoint infos based on a network id
- updates mock network manager find network id from net ns to reflect dualnic get network id behavior
(gets multiple networks because on deletion, you have one less endpoint that matches the netns/netnspath, and so use the network id of the other endpoint for deletion)
- updates windows tests to use eth1 to avoid mock endpoint client from throwing a duplicate endpoint id error
- separates windows and linux multitenancy tests because their behavior is different
- updates windows unit tests to allow passing in an expected num of endpoints for EACH network id after EACH command is run during delete test
@QxBytes QxBytes force-pushed the alew/backport-windows-uts branch from e3bc971 to d55388b Compare August 27, 2024 23:33
@QxBytes QxBytes marked this pull request as ready for review August 28, 2024 16:59
@QxBytes QxBytes requested review from a team as code owners August 28, 2024 16:59
@QxBytes QxBytes requested a review from jpayne3506 August 28, 2024 16:59
@QxBytes QxBytes force-pushed the alew/backport-windows-uts branch from 5bf6d4f to b94e54b Compare August 28, 2024 18:32
@QxBytes
Copy link
Contributor Author

QxBytes commented Aug 28, 2024

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@QxBytes QxBytes added this pull request to the merge queue Aug 28, 2024
Merged via the queue into release/v1.5 with commit e43adc3 Aug 28, 2024
11 checks passed
@QxBytes QxBytes deleted the alew/backport-windows-uts branch August 28, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Infra or tooling. cni Related to CNI. release/1.5 Change affects v1.5 release train
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants