Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UTs for CNI Windows Policy #2965

Merged
merged 7 commits into from
Aug 30, 2024
Merged

Add UTs for CNI Windows Policy #2965

merged 7 commits into from
Aug 30, 2024

Conversation

paulyufan2
Copy link
Contributor

Reason for Change:

This PR is to add UTs for CNI windows policy

Issue Fixed:

Requirements:

Notes:

@paulyufan2 paulyufan2 added the cni Related to CNI. label Aug 28, 2024
@paulyufan2 paulyufan2 requested a review from a team as a code owner August 28, 2024 03:16
@paulyufan2
Copy link
Contributor Author

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulyufan2 paulyufan2 enabled auto-merge August 28, 2024 15:53
@paulyufan2 paulyufan2 force-pushed the windowsPolicyUT branch 2 times, most recently from 22a7bc1 to 8883994 Compare August 29, 2024 17:52
@paulyufan2 paulyufan2 disabled auto-merge August 29, 2024 17:52
@paulyufan2
Copy link
Contributor Author

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

QxBytes
QxBytes approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@QxBytes QxBytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up on GetHcnEndpointPolicies intended behavior as it only seems to select one type of policy based on the parameter ("EndpointPolicy" type).

@paulyufan2 paulyufan2 enabled auto-merge August 30, 2024 00:55
@paulyufan2 paulyufan2 added this pull request to the merge queue Aug 30, 2024
@paulyufan2 paulyufan2 removed this pull request from the merge queue due to a manual request Aug 30, 2024
@paulyufan2 paulyufan2 added this pull request to the merge queue Aug 30, 2024
Merged via the queue into master with commit fc933e2 Aug 30, 2024
14 checks passed
@paulyufan2 paulyufan2 deleted the windowsPolicyUT branch August 30, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QxBytes QxBytes QxBytes approved these changes

@chengch801214 chengch801214 Awaiting requested review from chengch801214 chengch801214 is a code owner automatically assigned from Azure/azure-sdn-members

@tamilmani1989 tamilmani1989 Awaiting requested review from tamilmani1989

Assignees
No one assigned
Labels
cni Related to CNI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulyufan2 @QxBytes