fix: make ipamv2 metrics resilient to missing custom resource definitions #3029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
force-pushed
the
fix/ipamv2-metrics
branch
from
b34b67d to
ae2bfc9
Compare
rbtr
force-pushed
the
fix/ipamv2-metrics
branch
from
ae2bfc9 to
d842827
Compare
…ions Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
rbtr
force-pushed
the
fix/ipamv2-metrics
branch
from
d842827 to
fb81db6
Compare
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
lgtm, although this behavior (potentially missing data sources/ errors that affects the metrics) is unique to ipam v2 right? |
|
yes, due to how ipamv2 pulls the CRs directly (since it doesn't already have them, like ipamv1 did) |
nddq
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
The metrics observer added in #2970 fails fast if a source of metrics is unavailable. This prevents legacy metrics from being collected at all in scenarios like (as occurred) the ClusterSubnetState custom resource definition is not installed in the cluster.
In this change, the observer is made resilient to missing data sources or errors in the data collection, and will make a best-effort attempt to record the metrics even in case of partial data availability.
Issue Fixed:
Requirements:
Notes: