ci: combine go tests such that any test failure will report a failure for the entire task #3156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QxBytes
added
ci
timraymond
reviewed
Nov 19, 2024
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
QxBytes
force-pushed
the
alew/add-set-ex-ut
branch
3 times, most recently
from
a16740d to
ac91b06
Compare
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
QxBytes
added
exempt-stale
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
Pull request closed due to inactivity. |
QxBytes
force-pushed
the
alew/add-set-ex-ut
branch
from
6b4e7df to
35d4e37
Compare
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
4 tasks
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
timraymond
approved these changes
Jan 22, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to Branch Protection failures
You're not authorized to push to this branch. Visit "About protected branches" for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
When the go tests are split up, only the status of the last command run determines the status of the entire step/task. Any previous steps, even if they exited with a failure, won't cause the task to visibly fail. By combining all tests together in one command, if this single command fails (due to any of the tests failing), the step/task will visibly fail on the pipeline.
Issue Fixed:
See above
Requirements:
Notes:
Will fail in the pipeline until npm windows tests are fixed (this is expected, as previously those tests were silently failing).
When those npm changes are merged in, I will rebase this PR against master to resolve the errors.
Will be backported to
release/v1.5