Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In case of mount and mount all, if the container name has '$' do not treat it as env variable #1637

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

vibhansa-msft
Copy link
Member

@vibhansa-msft vibhansa-msft commented Feb 19, 2025

Type of Change

  • Bug fix
  • New feature
  • Code quality improvement
  • Other (describe):

Description

In case of mount all or while mounting Azure special container like "$web", expandPath assumes it's an enviornment variable and tries to expand it while it shall skip these special container names. As part of this change we will not expand any environment variable in any path or config file name if env variable name matches reserved Azure Container name.

How Has This Been Tested?

UT has been added and related bug has been linked.

Checklist

  • The purpose of this PR is explained in this or a referenced issue.
  • Tests are included and/or updated for code changes.
  • Documentation update required.
  • Updates to module CHANGELOG.md are included.
  • License headers are included in each file.

Related Links

NA

@syeleti-msft
Copy link
Member

syeleti-msft commented Feb 20, 2025

is this pr about container name having $ symbol or config file path having $ symbol, seems ambiguous to me!

@vibhansa-msft
Copy link
Member Author

is this pr about container name having $ symbol or config file path having $ symbol, seems ambiguous to me!

Issue is both with mount path and config file name having "$" in their names.

@syeleti-msft
Copy link
Member

is this pr about container name having $ symbol or config file path having $ symbol, seems ambiguous to me!

Issue is both with mount path and config file name having "$" in their names.

Then it is basically about filepath having $ symbol in it. I don't understand the description stating that container name is having $ in it. If it is not, then please modify the description

@vibhansa-msft
Copy link
Member Author

is this pr about container name having $ symbol or config file path having $ symbol, seems ambiguous to me!

Issue is both with mount path and config file name having "$" in their names.

Then it is basically about filepath having $ symbol in it. I don't understand the description stating that container name is having $ in it. If it is not, then please modify the description

Expanded description.

@vibhansa-msft vibhansa-msft merged commit 7bf2f11 into main Feb 22, 2025
10 checks passed
@vibhansa-msft vibhansa-msft deleted the vibhansa/special_container_expand_restrict branch February 22, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use "mount all" when a container exists with a $ sign in the name (like "$web")
3 participants