Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return the detailed error when the connection fails #1648

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

return the detailed error when the connection fails #1648

wants to merge 6 commits into from

Conversation

syeleti-msft
Copy link
Member

@syeleti-msft syeleti-msft commented Mar 4, 2025 •
edited
Loading

Type of Change

  • Bug fix
  • New feature
  • Code quality improvement
  • Other (describe):

Description

  • Improvement: (Brief description of the feature or issue being addressed)
    Display the detailed error if the mount fails
    Ex: if the container dont exists, while mounting:
    Before change:
    Error: failed to authenticate credentials for azstorage
    After change:
    Error: failed to initialize new pipeline [failed to authenticate credentials for azstorage, [BlockBlob: [ContainerNotFound]]]
    Error: failed to initialize new pipeline [failed to authenticate credentials for azstorage, [Datalake: [FilesystemNotFound]]]

How Has This Been Tested?

UT's are included

Checklist

  • The purpose of this PR is explained in this or a referenced issue.
  • Tests are included and/or updated for code changes.
  • Documentation update required.
  • Updates to module CHANGELOG.md are included.
  • License headers are included in each file.

Related Links

@syeleti-msft syeleti-msft mentioned this pull request Mar 4, 2025
Open
@vibhansa-msft vibhansa-msft added this to the v2-2.5.0 milestone Mar 4, 2025
syeleti-msft and others added 2 commits March 4, 2025 19:18
@syeleti-msft @vibhansa-msft
Update component/azstorage/block_blob.go
d1cbd25 
Co-authored-by: Vikas Bhansali <64532198+vibhansa-msft@users.noreply.github.com>
@syeleti-msft @vibhansa-msft
Update component/azstorage/datalake.go
1c5a2c1 
Co-authored-by: Vikas Bhansali <64532198+vibhansa-msft@users.noreply.github.com>
@vibhansa-msft vibhansa-msft linked an issue Mar 5, 2025 that may be closed by this pull request
provide container not found error directly in blobfuse mount error when --container-name does not exist #1647
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vibhansa-msft vibhansa-msft vibhansa-msft left review comments

@jainakanksha-msft jainakanksha-msft jainakanksha-msft approved these changes

@souravgupta-msft souravgupta-msft Awaiting requested review from souravgupta-msft souravgupta-msft is a code owner

@ashruti-msft ashruti-msft Awaiting requested review from ashruti-msft ashruti-msft is a code owner

Assignees
No one assigned
Labels
pr-ready-for-review
Projects
None yet
Milestone
v2-2.5.0
Development

Successfully merging this pull request may close these issues.

provide container not found error directly in blobfuse mount error when --container-name does not exist
3 participants
@syeleti-msft @vibhansa-msft @jainakanksha-msft