reduce code smells #727
Merged
reduce code smells #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjjasper
force-pushed
the
chore/fix-sonar-complaints
branch
from
ae4a88a to
a4085fa
Compare
jjjasper
commented
Jan 4, 2024
| try (OutputStream outputStream = new ByteArrayOutputStream()) { | ||
| render.render(changedOpenApi, new OutputStreamWriter(outputStream)); | ||
| return outputStream.toString(); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
Should not throw generic RuntimeException
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix one new code smell introduced by me.
Fix some low-hanging fruits code smells.