Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Allow specific signing for debug and release #251

Merged
merged 5 commits into from
Jan 28, 2025

Conversation

GMinucci
Copy link
Collaborator

What does this PR do

Adds the capability to specify signing for debug and/or release for each variant. This also includes a new option to allow automatic signing.

How can it be tested

Use the new properties (debug_signing and release_signing) following the provided docs and see them applied to the project once you run variants switch commad

Task

resolves #241

Checklist:

  • I ran make validation locally with success
  • I have not introduced new bugs
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new errors

@GMinucci GMinucci self-assigned this Jan 28, 2025
Copy link

github-actions bot commented Jan 28, 2025

Warnings
⚠️ Pull request is relatively big. If this PR contains multiple changes, consider splitting it into separate PRs for easier reviews.

Generated by 🚫 Danger Swift against fffce90

@GMinucci GMinucci merged commit 5b0f7a4 into develop Jan 28, 2025
9 checks passed
@GMinucci GMinucci deleted the feat/diff-signing-for-debug-and-release branch January 28, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Configuration specific signing
2 participants