-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Automatically detect signing certificate #252
base: develop
Are you sure you want to change the base?
Feat: Automatically detect signing certificate #252
Conversation
With this approach we will always try first to set automatically which could break in case the first cert is not valid anymore. Let's make this a new feature that can be enabled so we avoid breaking previous versions. signing:
...
codesign_identity: <option> And the options could be:
What are your thoughts on this @shehan-bb @arthurpalves ? |
Yes, this can be useful to avoid any unexpected behaviour. |
What does this PR do
Adds the capability to retrieve the signing certificate name from the Keychain if exists from the team id provided.
How can it be tested
Use a TeamID of a signing certificate present in the keychain access in the properties and see if the correct certificate name is populated in the xcodeproj file after
variants switch
commandTask
resolves #239
Checklist:
make validation
locally with success