Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Automatically detect signing certificate #252

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

shehan-bb
Copy link
Contributor

@shehan-bb shehan-bb commented Jan 30, 2025

What does this PR do

Adds the capability to retrieve the signing certificate name from the Keychain if exists from the team id provided.

How can it be tested

Use a TeamID of a signing certificate present in the keychain access in the properties and see if the correct certificate name is populated in the xcodeproj file after variants switch command

Task

resolves #239

Checklist:

  • I ran make validation locally with success
  • I have not introduced new bugs
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new errors

@shehan-bb shehan-bb marked this pull request as draft January 30, 2025 12:05
@shehan-bb shehan-bb changed the title DRAFT: Feat: Automatically detect signing certificate Feat: Automatically detect signing certificate Jan 30, 2025
@shehan-bb shehan-bb marked this pull request as ready for review February 3, 2025 14:13
@GMinucci
Copy link
Collaborator

GMinucci commented Feb 4, 2025

With this approach we will always try first to set automatically which could break in case the first cert is not valid anymore. Let's make this a new feature that can be enabled so we avoid breaking previous versions.
This is an example of

signing:
    ...
    codesign_identity: <option> 

And the options could be:

  1. auto_detect_system -> This uses the new mechanism, fallback to option 2 if cant find any
  2. auto_name -> This is the previous approach (make this the default)
  3. user inputted value -> This should set whatever the user set in the configuration for full control

What are your thoughts on this @shehan-bb @arthurpalves ?

@shehan-bb
Copy link
Contributor Author

shehan-bb commented Feb 4, 2025

With this approach we will always try first to set automatically which could break in case the first cert is not valid anymore. Let's make this a new feature that can be enabled so we avoid breaking previous versions. This is an example of

signing:
    ...
    codesign_identity: <option> 

And the options could be:

  1. auto_detect_system -> This uses the new mechanism, fallback to option 2 if cant find any
  2. auto_name -> This is the previous approach (make this the default)
  3. user inputted value -> This should set whatever the user set in the configuration for full control

What are your thoughts on this @shehan-bb @arthurpalves ?

Yes, this can be useful to avoid any unexpected behaviour.

@shehan-bb shehan-bb closed this Feb 4, 2025
@shehan-bb shehan-bb reopened this Feb 4, 2025
@GMinucci GMinucci self-requested a review February 7, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Automatically detect signing certificate type
2 participants