Ontmoetingsformulier changes #611
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added encounterID as foreign key on comments, to add comments directly to ontmoetingsformulier - added input new input types for games, comments and encounter competitions
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
ik heb de Contributor Licentie Overeenkomst gelezen en verklaar mij hiermee akkoord |
|
recheck |
roberttullycarr
changed the base branch from
develop
to
pandapanda_development
cskiwi
reviewed
Feb 26, 2025
| @Index | ||
| @Field(() => ID, { nullable: true }) | ||
| @Column(DataType.UUIDV4) | ||
| encounterId?: string; |
There was a problem hiding this comment.
This field isn't needed, this is handeled by the linkId and linkType
|
|
||
| @InputType() | ||
| export class GameNewInput extends PartialType( | ||
| OmitType(Game, ['id', 'visualCode', "rankingPoints", "players", 'competition','linkId', 'linkType', "tournament", "createdAt", "updatedAt"] as const), |
There was a problem hiding this comment.
I usually take the updatemodel as base so:
OmitType(GameUpdateInput, ['id'] as const),
| @@ -75,7 +75,8 @@ export class CommentResolver { | |||
| playerId: user.id, | |||
| linkId: newCommentData.linkId, | |||
| linkType: newCommentData.linkType, | |||
| clubId: newCommentData.clubId, | |||
| ...(newCommentData.clubId ? {clubId: newCommentData.clubId} : {}), | |||
| ...(newCommentData.encounterId ? {encounterId: newCommentData.encounterId} : {}), | |||
There was a problem hiding this comment.
same here, this value should be filled in on linkId
| gameId: game.id, | ||
| team: player.team, | ||
| player: player.player, | ||
| systemId: player.systemId, |
There was a problem hiding this comment.
system can be globally, and maybe even fetched here (so not passed from the client)
|
|
||
| if (gameData.players) { | ||
| for (const player of gameData.players) { | ||
| await GamePlayerMembership.create({ |
There was a problem hiding this comment.
Ranking for singles,doubles,mix are missing in the membership
|
|
||
| // if game is not a draw, update the score of the encounter | ||
| if (gameData.winner !== 0){ | ||
| await encounter.update({ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.