add encoding for opening json file #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had an UnicodeDecodeError caused when the icons.json file got opened. Error appeard on a ubuntu 20.04 server. (python 3.8.5.) On a windows and ubuntu 20.04 desktop maschine it works without the encoding
|
The frontend check didn't fails because of the commit I made. It's another issue I guess? |
|
I ran into th same problem today and the fix worked for me. Could be nice to have this in the next version 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had an UnicodeDecodeError caused when the icons.json file got opened. Error appeared on a ubuntu 20.04 server. (python 3.8.5.) On a windows and ubuntu 20.04 desktop maschine it worked without the encoding.