BUG: Fixing circular dependency happening for manifested files #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @BenjjinF - be great if we can get this commit in as it is stopping the manifest files. Let me know if we can assist? Thanks! |
|
@carderm Unfortunately I no longer work with Django. I will put a note in the readme stating that this repo is up for a new maintainer. |
RealOrangeOne
added a commit
to RealOrangeOne/django-fontawesome-6
that referenced
this pull request
Sep 2, 2022
This is a re-implementation of BenjjinF#21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just implemented the suggestion here: #14
Could someone review this - I haven't found a test setup for the project, so there is no test here yet.