Update about django dep #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
January 7, 2020 11:20
Replaced Django's ugettext (deprecated) with gettext to ensure the latest method for translations is in use. Also updated the string formatting from single to double quotes for better compatibility and code consistency. These changes enhance the overall code quality and ensures the updated code complies with PEP 8 style guide.
Several packages were updated in the package.json file of django-fontawesome-5 to their latest versions, including "postcss-import", "postcss-preset-env", "postcss-reporter", "rollup-plugin-postcss", "sass", "stylelint" and "stylelint-scss". Package-lock.json was also updated accordingly. The reason for these updates is to keep the project dependencies up-to-date and to potentially benefit from any bug fixes, improvements or new features in the latest versions of these packages.
The import for Django 'ugettext' was updated to 'gettext' in 'fields.py' to reflect the name change made in Django 3.0. This ensures the translation utility stays compatible with the newer versions of Django. Additionally, a new folder '.idea' was added to the '.gitignore' file. This prevents the inclusion of JetBrains IDE settings in future commits, which is an overhead that is not necessary for the functioning of the project.
This commit renames the import for Django from 'ugettext' to 'gettext' in 'fields.py', as per Django's 3.0 update. This maintains compatibility with the latest version of Django. Additionally, '.idea' has been included in the repository's '.gitignore' to exclude JetBrains IDE settings from future commits, reducing unnecessary overhead.
This commit introduces the 'pyproject.toml' file containing the necessary information and dependencies for the 'django-fontawesome-5' project. This new configuration provides key metadata about the project such as name, version, author, maintainers, Python requirement, and dependencies. It also specifies the readme file and its type.
…tion This commit updates the pyproject.toml file of the django-fontawesome-5 project to include better metadata and build configuration. Additions include a build system configuration, keywords, correct a typo in the version number, and a license. Additional configurations for setuptools and package data are also put in place. The changes will enhance the project's meta information and improve the build process.
Removed setup.py file as project is transitioning to use pyproject.toml for packaging and distribution configuration. Description of the package updated in pyproject.toml to match what was in the removed setup.py. Package metadata and resources inclusion also adjusted in the toml file for more current project state.
Added a 'where' clause in [tool.setuptools.package-data] in pyproject.toml to ensure that all packages are properly included during the build. This resolves an issue where some packages might not have been included due to a missing 'where' clause.
Introduced an inclusion tag, "icon_as_html", to allow better customization of the FontAwesome icons in templating. Loading of the static files has been adjusted for better script organization. The ordering of the imported modules has been changed for better readability following PEP8. Reorganization of the raw code was made for better readability and easier maintenance of the code moving forward. Furthermore, the function "icon_as_html" has been outfitted with better typing and documentation for better understanding of the function's capability. The entirety of these changes improves the overall functionality and readability of the code, leading to better user experience when employing django-fontawesome-5.
Updated the pyproject.toml file in the django-fontawesome-5 project by reordering imported modules and reorganizing the raw code for better readability and maintenance. Also, introduced an "icon_as_html" inclusion tag for enhanced FontAwesome icons customization in templates. Adjusted loading of static files for improved script organization, and added better typing and documentation to "icon_as_html" function for a more comprehensive understanding of its capabilities. This enhances code functionality and overall user experience.
The pyproject.toml file in the django-fontawesome-5 project is modified to include ".html", ".js", and ".css" files under the package data. This ensures the included formats are correctly packaged during distribution. This makes our package more reliable as we ensure all necessary static files are included in the distribution and available for usage.
Added descriptive CSS classes to Fontawesome CSS file enabling clear positioning of icons. Additionally, Adjusted JS import for Django-fontawesome package to import module properly. This improves icon rendering and positioning within the project. The JS changes also ensure compatibility with ES6 version of JS and other modern frameworks.
In the fontawesome_5.py file, the method used to retrieve the predefined font icon prefix was revised. Before, it would use a static value from the settings module. Now it uses the get_prefix function from the app settings module, providing more flexibility when configuring the icons' prefix. This enhancement allows easier customization of icon prefixes and enhances the overall usability of the Django-fontawesome-5 package. This change improves the flexibility and ease of using and customizing Fontawesome icons in Django projects.
Add a dependency to hatchling as build engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've made various updates on django-fontawesome-5 about django version and updates about building the wheel.