Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1007: show diff between expected and actual in repl #2706

Conversation

SebastianAas
Copy link
Contributor

What has changed?

This is how the displayed diff will look in the repl:
Screenshot 2025-01-20 at 07 24 42

Fixes #1007

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Made sure there is an issue registered with a clear problem statement that this PR addresses, (created the issue if it was not present).
    • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
  • Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
  • Confirmed that there are no linter warnings or errors (use the eslint extension, run npm run eslint before creating your PR, or run npm run eslint-watch to eslint as you go).

Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik

Copy link

netlify bot commented Jan 20, 2025

Deploy Preview for calva-docs ready!

Name Link
🔨 Latest commit 3455b85
🔍 Latest deploy log https://app.netlify.com/sites/calva-docs/deploys/678df6cc87a36b0008fb2d3e
😎 Deploy Preview https://deploy-preview-2706--calva-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PEZ
Copy link
Collaborator

PEZ commented Jan 20, 2025

Thanks! Can you check what the output looks like when using the "terminal" output destination? With some luck we have colored diffs there. 😄

@SebastianAas
Copy link
Contributor Author

This is the output from the terminal:
Screenshot 2025-01-20 at 09 53 49

Doesn't look like it has any colors for now.

Using test explorer:
Screenshot 2025-01-20 at 08 59 56

@PEZ PEZ merged commit 9abf288 into BetterThanTomorrow:dev Jan 20, 2025
5 checks passed
@PEZ
Copy link
Collaborator

PEZ commented Jan 20, 2025

Thanks. We shouldn't be using clojure line comments there, but that's not introduced by your change. If you want to fix it, and also maybe look at if we can color code the diff for the terminal, that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants