Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android Debugging EINVAL Error in Windows for VSCode 1.92 #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cosineai[bot]
Copy link

@cosineai cosineai bot commented Oct 17, 2024

This pull request addresses the issue where launching Android debugging in Visual Studio Code 1.92 on Windows results in a 'spawn EINVAL' error. The error is linked to a security change in Node.js as detailed in the April 2024 security releases.

Changes Made:

  • Refactored the RunAndroid class to include a baseFn method that handles the Android run process.
  • Introduced getTarget and runAndroid methods to encapsulate target-specific logic and execution.
  • Updated RunAndroidDevice and RunAndroidSimulator classes to use the new getTarget method for determining the target type.

These changes ensure that the Android debugging process is correctly initialized and executed, resolving the EINVAL error. This refactoring also improves code organization and readability by encapsulating platform-specific logic within the RunAndroid class hierarchy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant