Fix Android Debugging EINVAL Error in Windows for VSCode 1.92 #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue where launching Android debugging in Visual Studio Code 1.92 on Windows results in a 'spawn EINVAL' error. The error is linked to a security change in Node.js as detailed in the April 2024 security releases.
Changes Made:
RunAndroid
class to include abaseFn
method that handles the Android run process.getTarget
andrunAndroid
methods to encapsulate target-specific logic and execution.RunAndroidDevice
andRunAndroidSimulator
classes to use the newgetTarget
method for determining the target type.These changes ensure that the Android debugging process is correctly initialized and executed, resolving the EINVAL error. This refactoring also improves code organization and readability by encapsulating platform-specific logic within the
RunAndroid
class hierarchy.