Python: add RANDOMKEY command #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-congo
commented
Jun 27, 2024
•
aaron-congo
commented
- also updates the redis-rs module to point to the latest commit in redis-rs/main
GumpacG
approved these changes
Jun 27, 2024
yipin-chen
approved these changes
Jun 27, 2024
aaron-congo
commented
Jun 27, 2024
| @@ -285,7 +285,7 @@ impl StandaloneClient { | |||
| Some(ResponsePolicy::OneSucceeded) => future::select_ok(requests.map(Box::pin)) | |||
| .await | |||
| .map(|(result, _)| result), | |||
| Some(ResponsePolicy::OneSucceededNonEmpty) => { | |||
| Some(ResponsePolicy::FirstSucceededNonEmptyOrAllEmpty) => { | |||
There was a problem hiding this comment.
This was renamed in redis-rs, so I had to rename here to get the Rust code to build successfully
Yury-Fridlyand
approved these changes
Jun 27, 2024
| @pytest.mark.parametrize("protocol", [ProtocolVersion.RESP2, ProtocolVersion.RESP3]) | ||
| async def test_random_key(self, redis_client: TGlideClient): | ||
| async def test_cluster_client_random_key(self, redis_client: TGlideClient): |
There was a problem hiding this comment.
Suggested change
| async def test_cluster_client_random_key(self, redis_client: TGlideClient): | |
| async def test_cluster_client_random_key(self, redis_client: GlideClusterClient): |
And you can remove assert for client type then
There was a problem hiding this comment.
Good point, will address all of these when I push to upstream
| key = get_random_string(10) | ||
|
|
||
| # set a key in the database in case it was empty | ||
| # setup: delete all keys | ||
| assert isinstance(redis_client, GlideClusterClient) |
There was a problem hiding this comment.
Suggested change
| assert isinstance(redis_client, GlideClusterClient) |
| assert await redis_client.exists([result]) == 1 | ||
| @pytest.mark.parametrize("cluster_mode", [False]) | ||
| @pytest.mark.parametrize("protocol", [ProtocolVersion.RESP2, ProtocolVersion.RESP3]) | ||
| async def test_standalone_client_random_key(self, redis_client: TGlideClient): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.