Skip to content

Commit

Permalink
Merge pull request #1073 from jeanp413/fix-parseSchema-exception
Browse files Browse the repository at this point in the history
[REVIEW] parseSchemaPython can throw exceptions
  • Loading branch information
William Malpica authored Oct 12, 2020
2 parents 3d3b446 + 29c8bc3 commit 9d12cdc
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
13 changes: 7 additions & 6 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@

## Bug Fixes
- #918 Activate validation for GPU_CI tests results.
- #975 Fixed issue due to cudf orc api change
- #975 Fixed issue due to cudf orc api change
- #1017 Fixed issue parsing fixed with string literals
- #1019 Fix hive string col
- #1019 Fix hive string col
- #1021 removed an rmm include
- #1020 Fixed build issues with latest rmm 0.16 and columnBasisTest due to deprecated drop_column() function
- #1029 Fix metadata mistmatch due to parsedMetadata
Expand All @@ -27,13 +27,14 @@
- #1030 Avoid read _metadata files
- #1039 Fixed issues with parsers, in particular ORC parser was misbehaving
- #1038 Fixed issue with logging dirs in distributed envs
- #1048 Pinned google cloud version to 1.16
- #1048 Pinned google cloud version to 1.16
- #1052 Partial revert of some changes on parquet rowgroups flow with local_files=True
- #1054 Can set manually BLAZING_CHACHE_DIRECTORY
- #1053 Fixed issue when loading paths with wildcards
- #1057 Fixed issue with concat all in concatenating cache
- #1007 Fix arrow and spdlog compilation issues
- #1068 Just adds a docs important links and avoid the message about filesystem authority not found
- #1073 Fixed parseSchemaPython can throw exceptions
- #1074: Remove lock inside grow() method from PinnedBufferProvider
- #1071 Fix crash when loading an empty folder

Expand Down Expand Up @@ -73,9 +74,9 @@
- #936 Adding extern C for include files
- #941 Logging level (flush_on) can be configurable
- #947 Use default client and network interface from Dask
- #945 Added new separate thresh for concat cache
- #945 Added new separate thresh for concat cache
- #939 Add unit test for Project kernel
- #949 Implemented using threadpool for outgoing messages
- #949 Implemented using threadpool for outgoing messages
- #961 Add list_tables() and describe_table() functions
- #967 Add bc.get_free_memory() function

Expand Down Expand Up @@ -111,7 +112,7 @@
- #927 Fixed random segfault issue in parser
- #929 Update the GPUManager functions
- #942 Fix column names on sample function
- #950 Introducing config param for max orderby samples and fixing oversampling
- #950 Introducing config param for max orderby samples and fixing oversampling
- #952 Dummy PR
- #957 Fixed issues caused by changes to timespamp in cudf
- #962 Use new rmm API instead of get_device_resource() and set_device_resource() functions
Expand Down
5 changes: 2 additions & 3 deletions engine/bsql_engine/io/io.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,9 @@ class RegisterFileSystemLocalError(BlazingError):
"""RegisterFileSystemLocal Error."""
cdef public PyObject * RegisterFileSystemLocalError_ = <PyObject *>RegisterFileSystemLocalError

cdef cio.TableSchema parseSchemaPython(vector[string] files, string file_format_hint, vector[string] arg_keys, vector[string] arg_values,vector[pair[string,type_id]] extra_columns, bool ignore_missing_paths) nogil:
cdef cio.TableSchema parseSchemaPython(vector[string] files, string file_format_hint, vector[string] arg_keys, vector[string] arg_values,vector[pair[string,type_id]] extra_columns, bool ignore_missing_paths) nogil except *:
with nogil:
temp = cio.parseSchema(files,file_format_hint,arg_keys,arg_values,extra_columns, ignore_missing_paths)
return temp
return cio.parseSchema(files,file_format_hint,arg_keys,arg_values,extra_columns, ignore_missing_paths)

cdef unique_ptr[cio.ResultSet] parseMetadataPython(vector[string] files, pair[int,int] offset, cio.TableSchema schema, string file_format_hint, vector[string] arg_keys, vector[string] arg_values) nogil:
with nogil:
Expand Down

0 comments on commit 9d12cdc

Please sign in to comment.