Update to Bitcoin core 25.0

[BuildWithData]

Goal: update to bitcoin core 25.0

Overview
Updating to 25.0 should be only about updating env var BITCOIN, but that is not true bcs the URL for 25.0 public key fingerprints does not exist anymore, whereas it still available for pvs versions like 23.0 and 24.0

From 25.0 keys will always be found in a separate repo as explained here by @achow101

Currently both standup scripts grab the keys.txt file from target URL version and then download keys from a key-server as we can see here. However an analogus file like keys.txt with all fingerprints is not found in this new repo, but instead all public keys can be found for each release in the corresponding version folder.

On top of that in the builder-keys folder, it seems like we can find all updated public keys, so apperently there is no need to download public keys from a key-server as they can all be found in this folder

Solution
In this pull request keys are not downloaded from a key-server anymore, but instead first we download the new repo and second import keys from the builder-keys folder

Doubt/Question
Couldn't figure out how to use wget to download the new repo from github, ie git is installed here. Is this a problem ? asking this bcs adding another software on a machine, where we run a node, might introduce some vulnerability. I don't think this is the case as git is a well know piece of software, but again no experience on this matter

TODO

• test LinodeStandUp.sh
• test StandUp.sh
• test LinodeStandUp.sh by maintainer
• test StandUp.sh by maintainer
• do not forget to squash commits

NEXT STEP

If this pull gets merged, then this must be updated as example shows version 22.0 in bitcoin-22.0-x86_64-linux-gnu.tar.gz and the keys.txt file

[ChristopherA]

I personally would prefer that we don't use git to download the file, as that requires some setup and auth that I'd prefer not to leaving hanging around.

However, you should be able to wget it using magic GitHub URLs. For instance, here is the URL to get a zip of the full @Bitcoin/Bitcoin project https://github.com/bitcoin/bitcoin/archive/refs/heads/master.zip

[BuildWithData]

hi @ChristopherA,

managed to replace git with wget. Still necessary to install unzip though, is that ok ?

unzip generates a lot of logs which are appended to the standup.log, they can be dropped by adding the quite option -q when unzipping, should we do it ?

Was wondering if you could elaborate a little bit more on the issue you mentioned about auth... as said very little experience here from my side and it would be nice to learn more about it

[BuildWithData]

hi @shannona, could you give me a feedback here ? thanks