RequireNamedArgumentsAnalyzer: add support for exemptions #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExemptSymbolsBuilder is a helper for building sets of exempt symbols without bespoke logic per-analyzer. The AdditionalFile format is similar to Roslyn's BannedApiAnalyzer: https://github.com/dotnet/roslyn-analyzers/blob/3211f48253bc18560156d90dc5e710d35f7d03fa/src/Microsoft.CodeAnalysis.BannedApiAnalyzers/BannedApiAnalyzers.Help.md In this case the optional [;Description Text] is excluded from the format, as exemptions do not lead to user-facing messages. Comments are supported for developers to leave notes justifying the exemption.
j3parker
reviewed
Aug 12, 2024
| m_cancellationToken = context.CancellationToken; | ||
| } | ||
|
|
||
| public ImmutableHashSet<ISymbol> Build() => m_exemptions.ToImmutable(); |
There was a problem hiding this comment.
IReadOnlySet<T>/HashSet<T> has better performance
There was a problem hiding this comment.
(ImmutableHashSet<T> uses an implementation that makes functional edits cheaper, at the cost of making lookups slower.)
j3parker
previously approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExemptSymbolsBuilder is a helper for building sets of exempt symbols without bespoke logic per-analyzer.
The AdditionalFile format is similar to Roslyn's BannedApiAnalyzer: https://github.com/dotnet/roslyn-analyzers/blob/3211f48253bc18560156d90dc5e710d35f7d03fa/src/Microsoft.CodeAnalysis.BannedApiAnalyzers/BannedApiAnalyzers.Help.md
In this case the optional
[;Description Text]is excluded from the format, as exemptions do not lead to user-facing messages.Comments are supported for developers to leave notes justifying the exemption.