Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set partial trimming #265

Merged
merged 7 commits into from
May 2, 2023
Merged

Set partial trimming #265

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cd3118a
lets use a fixed version tahts passed in. sounds easier
gord5500 Apr 25, 2023
29572a8
add partial TrimMode property
gord5500 May 2, 2023
a9eaa28
Merge branch 'main' of github.com:Brightspace/bmx
gord5500 May 2, 2023
cf89ed6
Merge branch 'main' into set_partial_trimming
gord5500 May 2, 2023
832b8ec
Merge branch 'main' into set_partial_trimming
gord5500 May 2, 2023
ab3a8dc
irrelevant file
gord5500 May 2, 2023
fce8a66
Merge branch 'set_partial_trimming' of github.com:Brightspace/bmx int…
gord5500 May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/D2L.Bmx/D2L.Bmx.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're adding a BOM here. Did you use VS to edit this file? Can you set the encoding to be without BOM?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our editorconfig does set utf-8 (which means without BOM), but VS just doesn't respect that... 😠

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the linter we use is unfortunately not able to catch charset violations
editorconfig-checker/editorconfig-checker#85

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I saw that and thought it was weird and did edit through VS. I'll make a new pr to fix it


<PropertyGroup>
<TargetName>bmx</TargetName>
Expand All @@ -8,6 +8,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<WarningsAsErrors>nullable</WarningsAsErrors>
<TrimMode>partial</TrimMode>
</PropertyGroup>

<ItemGroup>
Expand Down