allow ignoring spells in all event types, fix spell list ignore checkbox not working as expected. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arser functions not just damage
|
Is there anything I could change about this for it to get accepted? |
|
@Bunny67 Would you mind fixing this bug please ? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternative to #18
I'm aware current 8.3 details does not implement this, and it's an additional feature, but it seems to be a useful one.
functions\link.luahas a_detalhes.spellid_ignoredwhich is the profile saved ignore list.This has no link to
Details.SpellsToIgnoreordamage_spells_to_ignorein the parser.This solution just allows for the ignore checkbox on the spell list to link with the parser, as well as allowing it to function as expected, and ignore the spell in all parsing rather than just spell_dmg.
fixes #16