Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support platforms that do not have native atomics #177

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

lu-zero
Copy link
Contributor

@lu-zero lu-zero commented Dec 27, 2024

Fixes #162

e.g. for esp32c3 and such you can see it building using

cargo build --target=riscv32imc-unknown-none-elf --features alloc --no-default-features --features portable-atomic/unsafe-assume-single-core

BurntSushi pushed a commit to lu-zero/jiff that referenced this pull request Dec 29, 2024
@BurntSushi
Copy link
Owner

I've fixed this PR up a little bit:

  • The mod sync was declared pub(crate) unnecessarily.
  • I added some light docs.
  • I added a CI job to test this.
  • Most critically, I stopped enabling alloc unconditionally in portable-atomic-util. Jiff requires alloc opt-in, so I moved it to alloc = ["serde?/alloc", "portable-atomic-util/alloc"]. (I think this doesn't matter so much right now since Jiff doesn't compile in no-alloc mode, but I hope it will soon and this would have been easy to overlook!)

@BurntSushi BurntSushi merged commit b451d57 into BurntSushi:master Dec 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support riscv32imc-unknown-none-elf
2 participants